Can you double check that your FTP upload of the modified file worked? The event detail should show the dates/times with this enabled
It's not a matter of my changes not making it to the server, I don't use FTP, and in any case I am editing the file from a shell on the server itself. The cause was my not realizing that hiding "repeats and times" would also hide dates as well. Times and Dates are different things, and the UI labelling in the options for Event Details says to hide times, not dates, yet does both. That option implies a feature that does not exist (which happened to be what I wanted) to hide repeats and times from the event detail summaries.
Re your all day event/unspecified time - the thinking behind this was for events that occur on a specific date but a non-specific time e.g. a birthday. It wasn't designed for multi-day non specific time events since it would only appear in the calendar once on the start day. I would recommend that you use a daily repeating all-day event for this type of situation.Geraint
I see. That isn't practical because then the date given for any day in a multi-day event would show it to be a single-day event when it's not. Your birthday example is in fact a single-day event that repeats, but there are many types of events that are in fact timeless multi-day but do not repeat. In my case, the events are art exhibitions where the artist's work is on display for a given range of dates. For example, if an exhibition runs from June 4 to June 11, I need it to give those dates for the start and end dates and have a single entry in the calendar since it is a single event. It wouldn't be right for the visitor to click to the event details and see it as a single-day event when it's not. Perhaps I'm misunderstanding how repeating single-day events work, so I'll play with that some more.
At a more basic level, I don't see in any case a reason for times to be displayed for any event that has been marked "All Day" and timeless. It doesn't make sense to have times showing 00:00:00-23:59:59 for such events, and it's inconsistent behavior for the times to be properly hidden for timeless single-day events yet not for multi-day events. It's a simple patch, too, since you can just add a test for $this->alldayevent before appending $this->start_time when building $sum in your output code for multi-day events. In my case I just removed adding the times to the string since there's no cases where I want them displayed.
Regardless, I had no difficulty patching out the source that adds the dates to multi-day events so now have my display appearing how I want. Thanks to opensource and your readable code!